Improved installation section of README #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whimboo
requested changes
Jul 9, 2020
There was a problem hiding this comment.
Thank you for your contribution, and sorry if it's hard to understand at the moment.
Instead of duplicating instructions I would be more in favor of just referencing a page that explains all the details. And what's better than the python guide website for virtualenv.
Added link to virtualenv guide. Also removed obsolete link to wiki.
|
Thanks a lot for your patch. This looks fine now, and I will get it merged immediately. |
whimboo
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed obsolete link to wiki (does it still exist somewhere?) . Also added virtualenv commands because otherwise 'python setup.py develop' fails.
For me as a beginner it was confusing why 'python setup.py develop' fails when I followed instructions. With this change, installation process for a new contributer should go smoother :)