Create GitHub Action to auto-publish to PyPI #683
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whimboo
requested changes
May 21, 2024
There was a problem hiding this comment.
Thank you @libialany for the first PR on this repository. I've taken a look at the suggested changes and additions. There are some questions and suggestions that I added inline. Could you please take a look? Thanks!
.github/workflows/release.yml
Outdated
| run: python -m build | ||
|
|
||
| - name: Publish package to PyPI | ||
| if: github.repository == 'mozilla/mozdownload' && github.event_name == 'push' && startsWith(github.ref, 'refs/tags') |
There was a problem hiding this comment.
Could we change the check for mozilla/mozdownload to the existence of the secret token identifier in the environment?
There was a problem hiding this comment.
Thank you for the advice.
|
FYI a new PR was created for the requested changes which is #686. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user: ${{ secrets.pypi_user }}password: ${{ secrets.pypi_password }}.