Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GitHub Action to auto-publish to PyPI #683

Closed
wants to merge 5 commits into from

Conversation

libialany
Copy link
Contributor

  • Configure repository secrets for user and password of PyPI authentication: user: ${{ secrets.pypi_user }} password: ${{ secrets.pypi_password }}.
  • Implement package uploads exclusively for tagged commits using the gh-action-pypi-publish.
  • Integrate the isolation feature by adding the pyproject.toml file.

Copy link
Contributor

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @libialany for the first PR on this repository. I've taken a look at the suggested changes and additions. There are some questions and suggestions that I added inline. Could you please take a look? Thanks!

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
run: python -m build

- name: Publish package to PyPI
if: github.repository == 'mozilla/mozdownload' && github.event_name == 'push' && startsWith(github.ref, 'refs/tags')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change the check for mozilla/mozdownload to the existence of the secret token identifier in the environment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the advice.

pyproject.toml Outdated Show resolved Hide resolved
@libialany libialany closed this May 22, 2024
@whimboo
Copy link
Contributor

whimboo commented May 28, 2024

FYI a new PR was created for the requested changes which is #686.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants