Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1763188 - Add Snap support using TC builds #1450

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bug 1763188 - Add Snap support using TC builds #1450

wants to merge 1 commit into from

Conversation

lissyx
Copy link

@lissyx lissyx commented Sep 11, 2023

No description provided.

@lissyx lissyx force-pushed the tc-snap-upstream branch 2 times, most recently from 55f2d73 to b03c395 Compare September 11, 2023 14:04
@lissyx lissyx force-pushed the tc-snap-upstream branch 4 times, most recently from 0384a85 to e9c2fa1 Compare November 20, 2023 14:12
@zzzeid zzzeid changed the title WIP Early Firefox Snap Usptream builds on TC usage WIP Early Firefox Snap Upstream builds on TC usage Nov 20, 2023
@lissyx lissyx force-pushed the tc-snap-upstream branch 11 times, most recently from b89c008 to 61cd39e Compare November 22, 2023 09:38
@lissyx lissyx changed the title WIP Early Firefox Snap Upstream builds on TC usage Bug 1763188 - Add Snap support using TC builds Nov 22, 2023
@lissyx lissyx marked this pull request as ready for review November 22, 2023 09:43
@lissyx lissyx force-pushed the tc-snap-upstream branch 6 times, most recently from 32409cc to 9a10b92 Compare November 23, 2023 11:38
@zzzeid zzzeid self-requested a review December 18, 2023 18:35
zzzeid
zzzeid requested changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@zzzeid zzzeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Looking good, this is the first pass, I have a few more comments that I need to dig more into mainly for launchers.py.

mozregression/bisector.py Outdated Show resolved Hide resolved
mozregression/bisector.py Outdated
Comment on lines 366 to 367
def __init__(self, **kwargs):
super(IntegrationHandler, self).__init__(**kwargs)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant. SnapHandler automatically inherits from IntegrationHandler and there is no additional functionality added here.

mozregression/bisector.py Show resolved Hide resolved
mozregression/cli.py Show resolved Hide resolved
mozregression/fetch_configs.py Show resolved Hide resolved
mozregression/launchers.py
@@ -616,3 +624,175 @@ def cleanup(self):
# always remove tempdir
if self.tempdir is not None:
remove(self.tempdir)


# Should this be part of mozrunner ?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to dig into this a little more, there might be a better place for this but will let you know on the second pass.

mozregression/launchers.py Outdated Show resolved Hide resolved
mozregression/launchers.py Outdated Show resolved Hide resolved
mozregression/launchers.py Show resolved Hide resolved
mozregression/main.py Outdated Show resolved Hide resolved
@lissyx
Copy link
Author

lissyx commented Apr 25, 2024

Bad discovery: installing an older version gets updated anyway, even blocking snap refreshes: https://bugs.launchpad.net/snapd/+bug/2039052:

$ mozregression --good 2024-02-01 --bad 2024-04-25 --app firefox-snap --allow-sudo --repo snap-stable 
 0:00.16 WARNING: You are using mozregression version 6.0.2.dev16+ga6f1e8d, however version 6.1.0 is available.
 0:00.16 WARNING: You should consider upgrading via the 'pip install --upgrade mozregression' command.
 0:00.16 INFO: Getting snap-stable builds between 2024-02-01 and 2024-04-25
 0:04.13 INFO: Using 3eba1c7082aa5d2e1198ff02e055c8ea1eb302fa (pushed on 2024-02-01 05:30:14) for date 2024-02-01
 0:04.13 INFO: Using 792c9892791495e8f13e77e5a78bfda83ab7a455 (pushed on 2024-04-25 09:41:16) for date 2024-04-25
 0:04.68 WARNING: Skipping build 792c98927914: Unable to find build info using the taskcluster route 'gecko.v2.mozilla-central.revision.792c9892791495e8f13e77e5a78bfda83ab7a455.firefox.amd64-stable'
 0:04.68 WARNING: Skipping build 1f3b4df016ac: Unable to find build info using the taskcluster route 'gecko.v2.mozilla-central.revision.1f3b4df016ac965dd3a2c97cb547c495364fdeef.firefox.amd64-stable'
 0:04.69 WARNING: Skipping build 3eba1c7082aa: Unable to find build info using the taskcluster route 'gecko.v2.mozilla-central.revision.3eba1c7082aa5d2e1198ff02e055c8ea1eb302fa.firefox.amd64-stable'
 0:05.30 WARNING: Skipping build 2333872b0f50: Unable to find build info using the taskcluster route 'gecko.v2.mozilla-central.revision.2333872b0f5028fa1f0e9236440fe58df07a0235.firefox.amd64-stable'
 0:05.30 WARNING: Skipping build 93128c0fb8fe: Unable to find build info using the taskcluster route 'gecko.v2.mozilla-central.revision.93128c0fb8fed778bd735f2dceb9301c1a8eaf07.firefox.amd64-stable'
 0:05.30 WARNING: Skipping build ec5140ea1b13: Unable to find build info using the taskcluster route 'gecko.v2.mozilla-central.revision.ec5140ea1b1384a44d1ce6e0271fc97472399e96.firefox.amd64-stable'
 0:05.81 WARNING: Skipping build a6957fa93614: Unable to find build info using the taskcluster route 'gecko.v2.mozilla-central.revision.a6957fa936149dccf133bd99e165c5879c2cb4d5.firefox.amd64-stable'
 0:06.48 WARNING: Skipping build 75e88a502730: Unable to find build info using the taskcluster route 'gecko.v2.mozilla-central.revision.75e88a502730293c79cf9430fde6be96ac55bcbb.firefox.amd64-stable'
 0:06.69 INFO: Testing good and bad builds to ensure that they are really good and bad...
 0:06.69 INFO: Using local file: /home/alex/.mozilla/mozregression/persist/366005a91eda-shippable--snap-stable--firefox_122.0-2.1_amd64.snap
 0:06.69 INFO: Running snap-stable build built on 2024-02-02 01:49:34.958000, revision 366005a9
firefox_95c8218ba 122.0-2.1 installé
General refreshes of "firefox_95c8218ba" held until 2024-04-26T16:14:47+02:00
firefox_95c8218ba 125.0.2-1 par Mozilla✓ mis à jour
Le canal  est fermé pour le paquet Snap firefox_95c8218ba ; renvoi temporaire vers le canal stable.
 0:33.56 INFO: Launching /snap/firefox_95c8218ba/current/usr/lib/firefox/firefox [True]
 0:33.56 INFO: Application command: snap run firefox_95c8218ba -profile /home/alex/snap/firefox_95c8218ba/common/.mozilla/firefox/tmp_mlobawb.mozrunner
 0:33.57 INFO: application_buildid: 20240419214016
 0:33.57 INFO: application_changeset: c5ee44e4135571bec3220340242f9189c59ca5ba
 0:33.57 INFO: application_name: Firefox
 0:33.57 INFO: application_repository: https://hg.mozilla.org/releases/mozilla-release
 0:33.57 INFO: application_version: 125.0.2
Was this integration build good, bad, or broken? (type 'good', 'bad', 'skip', 'retry' or 'exit' and press Enter): Gtk-Message: 16:15:08.811: Not loading module "atk-bridge": The functionality is provided by GTK natively. Please try to not load it.
/usr/share/libdrm/amdgpu.ids: No such file or directory
firefox_95c8218ba supprimé

Interrupted.
 1:04.70 INFO: Last good revision: 366005a91eda9c0b765207a0623b7a9e46d9dea8
 1:04.70 INFO: First bad revision: 3de3f9428f138bf269718fceb36c5112a195ca37
 1:04.70 INFO: Pushlog:
None/pushloghtml?fromchange=366005a91eda9c0b765207a0623b7a9e46d9dea8&tochange=3de3f9428f138bf269718fceb36c5112a195ca37

 1:04.70 INFO: To resume, run:
 1:04.70 INFO: /home/alex/codaz/Mozilla/Snap/mozregression/venv/bin/mozregression --app firefox-snap --allow-sudo --repo=snap-stable --good=366005a91eda9c0b765207a0623b7a9e46d9dea8 --bad=3de3f9428f138bf269718fceb36c5112a195ca37

@lissyx lissyx force-pushed the tc-snap-upstream branch 7 times, most recently from 25ca7f4 to 653740e Compare October 29, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzzeid zzzeid zzzeid requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lissyx @zzzeid