fetch_configs: fix MRO in FirefoxL10nConfig (bug 1874400) #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzeid
changed the title
cgsheeh
approved these changes
Jan 12, 2024
Can you clarify? There are 7 classes that extend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was in the correct order for
ThunderbirdL10nConfig, however this was not the case forFirefoxL10nConfig. This PR fixes this problem, ensuring that the definition for the build regex is defined correctly.Edit: also move
CommonConfigto the right inThunderbirdL10nConfig, sinceThunderbirdL10nNightlyConfigMixinmay have been overridden in that case as well.