workflows: add virus scan check (bug 1881777) #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzeid
force-pushed
the
zeid/bug-1881777-virustotal
branch
from
44c52ac
to
d389694
Compare
cgsheeh
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Makes sense. Can we somehow automate submission to https://www.microsoft.com/en-us/wdsi/filesubmission too?
I haven't looked at ways of doing this. However, since not every release will result in false positives, and even in the case of such false positives, getting the results from MS malware analysis could take a long time, and thus the value of automating this may not be worthwhile. It is mainly added to help prevent publishing of Windows executables that will not run, thus saving users from needlessly upgrading/downgrading. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add VirusTotal scan script and job in workflow.