Add some options for bundle when create the installer on windows #224
Conversation
| @@ -80,14 +80,21 @@ def do_bundle(options): | |||
| if os.path.isdir(dirname): | |||
| shutil.rmtree(dirname) | |||
| # create a intaller | |||
| if IS_WIN: | |||
There was a problem hiding this comment.
We don't need the IS_WIN check yet - for now this part of the script is windows only (we will make it work for linux with the next bug). So please remove it for now. Also, the default values for python_path and nsis_path can be defined as a default= argument in the add_argument call, so you can just remove all this block.
There was a problem hiding this comment.
Hm, I see. But when we call bundle under linux, the default argument will be also given to bundle if we forget to give a python path. So, why don't we set different default value of path when we call different bundle funtion?
There was a problem hiding this comment.
Well, we will! But it is for the next patch - for now, the bundle command is only used in windows, so let keep things simple.
There was a problem hiding this comment.
I mean you can treat this patch as a windows bundle function.
python_path = 'C:\Python27'
nsis_path = 'C:\NSIS'
And, we when bundle be called under Linux system.
python_path = /usr/lib/python2.7
There was a problem hiding this comment.
The goal of this patch is to remove the environment variables used to use command line arguments instead. Let's just do this for now, and not something else - it is easy to do, and easy to review. Let's talk on irc about that!
There was a problem hiding this comment.
I see. :)
Sorry, I have some classes this afternoon. I will send you email after that. Let's fix this issue first. :D
MikeLing
force-pushed
the
Bugfix-1161542
branch
2 times, most recently
from
8e03b49
to
893db77
Compare
MikeLing
force-pushed
the
Bugfix-1161542
branch
2 times, most recently
from
f0f3ef8
to
80717e2
Compare
Add some options for bundle when create the installer on windows
No description provided.