Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bin): consider env when no verbosity flag is set #1848

Merged
merged 3 commits into from
Apr 25, 2024
Merged

fix(bin): consider env when no verbosity flag is set #1848

merged 3 commits into from
Apr 25, 2024

Commits on Apr 19, 2024

  1. fix(bin): consider env when no verbosity flag is set 

    There are two ways to specify the maximum log level of `neqo-server` and
`neqo-client`. Via the `RUST_LOG` environment variable and since
mozilla#1692 via the verbosity flags (e.g. `-v`).

Previously, if no verbosity flag was provided, `INFO` was set as the maximum log
level, the `RUST_LOG` environment variable was simply ignored.

With this commit, if no flag is set, the `RUST_LOG` environment variable is
considered, and only then the `env_logger` crate default value (`ERROR`) is used.

In other words, the precedence order now is:

1. command line flags (e.g. `-v`)
2. `RUST_LOG` environment variable
3. default `ERROR` level
    @mxinden
    mxinden committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    6ddc7d2 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. clippy

    @mxinden
    mxinden committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    d32daf3 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Move verbose into SharedArgs

    @mxinden
    mxinden committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    b61dd01 View commit details
    Browse the repository at this point in the history