Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Try and fix CI Fx build #1893

Merged
merged 6 commits into from
May 8, 2024
Merged

ci: Try and fix CI Fx build #1893

merged 6 commits into from
May 8, 2024

Conversation

larseggert
Copy link
Collaborator

No description provided.

@mxinden mxinden mentioned this pull request May 8, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

Failed Interop Tests

QUIC Interop Runner, client vs. server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

Benchmark results

Performance differences relative to 35c157b.

  • drain a timer quickly time: [309.74 ns 317.55 ns 324.86 ns]
    change: [-1.0623% +1.1964% +3.7580%] (p = 0.32 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 1+1 entries
    time: [194.44 ns 194.86 ns 195.28 ns]
    change: [-0.4908% -0.0317% +0.4618%] (p = 0.90 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 3+1 entries
    time: [239.26 ns 239.75 ns 240.30 ns]
    change: [-2.4290% -0.8348% +0.1454%] (p = 0.29 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 10+1 entries
    time: [239.09 ns 239.84 ns 240.75 ns]
    change: [-0.8932% +0.8419% +3.5533%] (p = 0.63 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 1000+1 entries
    time: [218.31 ns 218.53 ns 218.76 ns]
    change: [-6.9866% -2.3714% +0.4426%] (p = 0.37 > 0.05)
    No change in performance detected.

  • RxStreamOrderer::inbound_frame()
    time: [119.97 ms 120.10 ms 120.32 ms]
    change: [+0.8867% +1.0325% +1.2329%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • transfer/Run multiple transfers with varying seeds
    time: [120.37 ms 120.64 ms 120.92 ms]
    thrpt: [33.080 MiB/s 33.156 MiB/s 33.231 MiB/s]
    change:
    time: [+0.2394% +0.5689% +0.9104%] (p = 0.00 < 0.05)
    thrpt: [-0.9022% -0.5657% -0.2389%]
    Change within noise threshold.

  • transfer/Run multiple transfers with the same seed
    time: [120.31 ms 120.56 ms 120.82 ms]
    thrpt: [33.107 MiB/s 33.177 MiB/s 33.247 MiB/s]
    change:
    time: [+0.5138% +0.8051% +1.0998%] (p = 0.00 < 0.05)
    thrpt: [-1.0878% -0.7987% -0.5111%]
    Change within noise threshold.

  • 1-conn/1-100mb-resp (aka. Download)/client
    time: [1.1338 s 1.1399 s 1.1455 s]
    thrpt: [87.295 MiB/s 87.725 MiB/s 88.199 MiB/s]
    change:
    time: [+0.8428% +1.5999% +2.3161%] (p = 0.00 < 0.05)
    thrpt: [-2.2637% -1.5747% -0.8358%]
    Change within noise threshold.

  • 1-conn/10_000-parallel-1b-resp (aka. RPS)/client
    time: [428.14 ms 430.51 ms 432.94 ms]
    thrpt: [23.098 Kelem/s 23.228 Kelem/s 23.357 Kelem/s]
    change:
    time: [-0.8264% -0.0870% +0.6500%] (p = 0.82 > 0.05)
    thrpt: [-0.6458% +0.0870% +0.8333%]
    No change in performance detected.

  • 1-conn/1-1b-resp (aka. HPS)/client
    time: [49.689 ms 49.818 ms 49.972 ms]
    thrpt: [20.011 elem/s 20.073 elem/s 20.125 elem/s]
    change:
    time: [-0.3871% +0.0134% +0.3680%] (p = 0.95 > 0.05)
    thrpt: [-0.3666% -0.0134% +0.3886%]
    No change in performance detected.

Client/server transfer results

Transfer of 134217728 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 609.3 ± 244.9 373.4 990.8 1.00
neqo msquic reno on 846.9 ± 168.7 731.8 1307.4 1.00
neqo msquic reno 879.3 ± 256.8 742.4 1603.5 1.00
neqo msquic cubic on 842.1 ± 183.3 737.3 1357.1 1.00
neqo msquic cubic 904.1 ± 167.0 749.9 1169.3 1.00
msquic neqo reno on 5364.6 ± 213.2 4965.2 5672.2 1.00
msquic neqo reno 5308.4 ± 199.6 5092.4 5690.0 1.00
msquic neqo cubic on 5247.8 ± 392.5 4850.9 6233.8 1.00
msquic neqo cubic 5094.2 ± 258.3 4739.9 5580.8 1.00
neqo neqo reno on 4105.3 ± 402.3 3398.9 4775.6 1.00
neqo neqo reno 4471.7 ± 165.4 4132.7 4682.1 1.00
neqo neqo cubic on 4966.6 ± 266.4 4643.4 5612.1 1.00
neqo neqo cubic 4921.8 ± 145.6 4690.6 5089.8 1.00

⬇️ Download logs

@larseggert larseggert marked this pull request as ready for review May 8, 2024 13:38
@larseggert
Copy link
Collaborator Author

This seems to work 🤞 and also eliminates vendoring in an action.

@larseggert larseggert merged commit 3015218 into mozilla:main May 8, 2024
54 checks passed
@larseggert larseggert deleted the ci-fx-disk-space branch May 8, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KershawChang KershawChang Awaiting requested review from KershawChang KershawChang is a code owner

@martinthomson martinthomson Awaiting requested review from martinthomson martinthomson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@larseggert