refactor(transport): reuse now in qlog wherever available
#2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
mxinden
force-pushed
the
now-transport
branch
from
8ffb7a4
to
dc66eac
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2216 +/- ##
==========================================
+ Coverage 95.39% 95.40% +0.01%
==========================================
Files 112 112
Lines 36449 36585 +136
==========================================
+ Hits 34769 34904 +135
- Misses 1680 1681 +1 ☔ View full report in Codecov by Sentry. |
mxinden
force-pushed
the
now-transport
branch
from
dc66eac
to
dc62e94
Compare
Instead of using `QLogStream::add_event_data_now`, which internally calls `std::time::Instant::now()`, pass `now to `QLogStream::add_event_data_with_instant`.
mxinden
force-pushed
the
now-transport
branch
from
dc62e94
to
44c5e5a
Compare
mxinden
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
https://github.com/mozilla/neqo/actions/runs/11666011987/job/32480021975?pr=2216 I don't think this failure is related. Would be prevented by #2208. |
|
For the record, this pull request enables running the
|
larseggert
reviewed
Nov 6, 2024
|
Can we add a comment to the remaining uses of |
Benchmark resultsPerformance differences relative to 978aa4e. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [98.672 ns 98.944 ns 99.219 ns]
change: [-0.5506% -0.0565% +0.4121%] (p = 0.82 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [117.09 ns 117.43 ns 117.80 ns]
change: [-0.3542% +0.1538% +0.6210%] (p = 0.55 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.56 ns 117.06 ns 117.71 ns]
change: [-1.0138% -0.1902% +0.4502%] (p = 0.65 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.334 ns 97.503 ns 97.697 ns]
change: [-0.4667% +0.5481% +1.6101%] (p = 0.34 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.63 ms 111.69 ms 111.74 ms]
change: [-0.8367% -0.6430% -0.5110%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [26.405 ms 27.394 ms 28.385 ms]
change: [-6.0775% -1.0006% +4.3342%] (p = 0.72 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [33.676 ms 35.369 ms 37.044 ms]
change: [-11.499% -5.8089% +0.4386%] (p = 0.07 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [26.433 ms 27.340 ms 28.258 ms]
change: [-0.0465% +4.3537% +9.3912%] (p = 0.07 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [41.983 ms 44.093 ms 46.232 ms]
change: [-5.2329% +2.0660% +9.4893%] (p = 0.58 > 0.05)
1-conn/1-100mb-resp/mtu-1500 (aka. Download)/client: No change in performance detected. time: [934.05 ms 943.25 ms 952.59 ms]
thrpt: [104.98 MiB/s 106.02 MiB/s 107.06 MiB/s]
change:
time: [-2.0265% -0.7219% +0.4887%] (p = 0.27 > 0.05)
thrpt: [-0.4863% +0.7271% +2.0684%]
1-conn/10_000-parallel-1b-resp/mtu-1500 (aka. RPS)/client: No change in performance detected. time: [319.87 ms 322.68 ms 325.57 ms]
thrpt: [30.715 Kelem/s 30.990 Kelem/s 31.262 Kelem/s]
change:
time: [+0.0279% +1.3485% +2.6880%] (p = 0.05 > 0.05)
thrpt: [-2.6177% -1.3305% -0.0279%]
1-conn/1-1b-resp/mtu-1500 (aka. HPS)/client: No change in performance detected. time: [33.676 ms 33.826 ms 33.977 ms]
thrpt: [29.432 elem/s 29.563 elem/s 29.695 elem/s]
change:
time: [-0.5369% +0.2308% +1.0322%] (p = 0.57 > 0.05)
thrpt: [-1.0217% -0.2303% +0.5398%]
1-conn/1-100mb-resp/mtu-1500 (aka. Upload)/client: 💔 Performance has regressed. time: [1.6683 s 1.6887 s 1.7101 s]
thrpt: [58.476 MiB/s 59.219 MiB/s 59.939 MiB/s]
change:
time: [+1.7710% +3.6461% +5.5884%] (p = 0.00 < 0.05)
thrpt: [-5.2926% -3.5179% -1.7402%]
1-conn/1-100mb-resp/mtu-65536 (aka. Download)/client: No change in performance detected. time: [111.49 ms 112.01 ms 112.75 ms]
thrpt: [886.95 MiB/s 892.80 MiB/s 896.94 MiB/s]
change:
time: [-1.0833% -0.5571% +0.1328%] (p = 0.07 > 0.05)
thrpt: [-0.1326% +0.5602% +1.0952%]
1-conn/10_000-parallel-1b-resp/mtu-65536 (aka. RPS)/client: No change in performance detected. time: [316.57 ms 319.60 ms 322.65 ms]
thrpt: [30.993 Kelem/s 31.289 Kelem/s 31.588 Kelem/s]
change:
time: [-2.0759% -0.6684% +0.6961%] (p = 0.35 > 0.05)
thrpt: [-0.6912% +0.6728% +2.1199%]
1-conn/1-1b-resp/mtu-65536 (aka. HPS)/client: Change within noise threshold. time: [33.911 ms 34.125 ms 34.358 ms]
thrpt: [29.105 elem/s 29.304 elem/s 29.489 elem/s]
change:
time: [+0.0360% +0.9144% +1.8432%] (p = 0.05 < 0.05)
thrpt: [-1.8099% -0.9061% -0.0360%]
1-conn/1-100mb-resp/mtu-65536 (aka. Upload)/client: No change in performance detected. time: [268.41 ms 327.82 ms 400.31 ms]
thrpt: [249.81 MiB/s 305.05 MiB/s 372.57 MiB/s]
change:
time: [-19.445% +7.7182% +41.691%] (p = 0.63 > 0.05)
thrpt: [-29.424% -7.1652% +24.139%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
larseggert
approved these changes
Nov 11, 2024
Sorry, missed this earlier. Will address now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using
QLogStream::add_event_data_now, which internally callsstd::time::Instant::now(), passnowtoQLogStream::add_event_data_with_instantwherevernowis available.Less intrusive alternative to #2212.
Fixes #2211.