Merge pull request #18611 from calixteman/fix_telemetry

Fix the telemetry for the new alt-text flow
mozilla · Aug 15, 2024 · b60261e · b60261e
2 parents 17f387b + 9bd0085
commit b60261e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/display/editor/alt_text.js b/src/display/editor/alt_text.js
@@ -78,7 +78,7 @@ class AltText {
       if (this.#useNewAltTextFlow) {
         this.#editor._reportTelemetry({
           action: "pdfjs.image.alt_text.image_status_label_clicked",
-          label: this.#label,
+          data: { label: this.#label },
         });
       }
     };
@@ -237,7 +237,7 @@ class AltText {
       const type = label === "review" ? "to-review" : label;
       this.#editor._reportTelemetry({
         action: "pdfjs.image.alt_text.image_status_label_displayed",
-        label,
+        data: { label },
       });
       button.classList.toggle("done", !!this.#altText);
       AltText._l10nPromise

diff --git a/src/display/editor/stamp.js b/src/display/editor/stamp.js
@@ -108,7 +108,7 @@ class StampEditor extends AnnotationEditor {
   get telemetryFinalData() {
     return {
       type: "stamp",
-      hasAltText: this.hasAltTextData(),
+      hasAltText: !!this.altTextData?.altText,
     };
   }