Merge pull request #14325 from Snuffleupagus/getPageDict-rm-skipCount

Remove the unused `skipCount` parameter from `Catalog.getPageDict` (PR 14311 follow-up)
mozilla · Dec 2, 2021 · f61b74e · f61b74e
2 parents d9e0de8 + 8ea740c
commit f61b74e
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/src/core/catalog.js b/src/core/catalog.js
@@ -1085,7 +1085,7 @@ class Catalog {
     });
   }
 
-  getPageDict(pageIndex, skipCount = false) {
+  getPageDict(pageIndex) {
     const capability = createPromiseCapability();
     const nodesToVisit = [this._catDict.getRaw("Pages")];
     const visitedNodes = new RefSet();
@@ -1153,7 +1153,7 @@ class Catalog {
             throw ex;
           }
         }
-        if (Number.isInteger(count) && count >= 0 && !skipCount) {
+        if (Number.isInteger(count) && count >= 0) {
           // Cache the Kids count, since it can reduce redundant lookups in
           // documents where all nodes are found at *one* level of the tree.
           const objId = currentNode.objId;

diff --git a/src/core/document.js b/src/core/document.js
@@ -1388,7 +1388,7 @@ class PDFDocument {
       let pageIndex = 1; // The first page was already loaded.
       while (true) {
         try {
-          await this.getPage(pageIndex, /* skipCount = */ true);
+          await this.getPage(pageIndex);
         } catch (reasonLoop) {
           if (reasonLoop instanceof PageDictMissingException) {
             break;

diff --git a/test/unit/api_spec.js b/test/unit/api_spec.js
@@ -457,6 +457,14 @@ describe("api", function () {
       const pdfDocument = await loadingTask.promise;
       expect(pdfDocument.numPages).toEqual(1);
 
+      const page = await pdfDocument.getPage(1);
+      expect(page instanceof PDFPageProxy).toEqual(true);
+
+      const opList = await page.getOperatorList();
+      expect(opList.fnArray.length).toEqual(0);
+      expect(opList.argsArray.length).toEqual(0);
+      expect(opList.lastChunk).toEqual(true);
+
       await loadingTask.destroy();
     });