Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JPX Image with transparency shows inversed colors #16782

Closed
pubpub-zz opened this issue Aug 2, 2023 · 4 comments · Fixed by #18204
Closed

JPX Image with transparency shows inversed colors #16782

pubpub-zz opened this issue Aug 2, 2023 · 4 comments · Fixed by #18204
Labels
image-jpx

Comments

@pubpub-zz
Copy link

pubpub-zz commented Aug 2, 2023 •
edited
Loading

with the following PDF:
tt1.pdf

we are expecting this image:(available in AcrobatReader, Chrome, Sumatra,...)
image

but in pdf.js (windows 11 / firefox 115.02 + PDF.js: 3.7.96 [23958ffc5] the colors are inverted:
2023-08-02 23-00-07
@pubpub-zz pubpub-zz mentioned this issue Aug 2, 2023
Closed
@radarhere radarhere mentioned this issue Aug 3, 2023
Merged
@NextThread

This comment was marked as outdated.

Sign in to view
@pubpub-zz
Copy link
Author

@NextThread any update of your analysis?

@pubpub-zz
Copy link
Author

Is anyone interested in having a look in my issue ?

@Snuffleupagus Snuffleupagus mentioned this issue Dec 12, 2023
Closed
@pubpub-zz
Copy link
Author

@Snuffleupagus
I don't think the issue is a duplicate of #17416 where the channels seems to be puzzled whereas in here the image is color reversed.
For me still active

@radarhere radarhere mentioned this issue May 22, 2024
Open
@Snuffleupagus Snuffleupagus mentioned this issue May 31, 2024
Closed
@radarhere radarhere mentioned this issue Jun 2, 2024
Closed
@Snuffleupagus Snuffleupagus linked a pull request Jun 3, 2024 that will close this issue
Fix decoding of JPX images having an alpha channel #18204
Merged
jollaitbot pushed a commit to sailfishos-mirror/poppler that referenced this issue Nov 11, 2024
@nbenitez @tsdgeos
cairo: Fix rendering of JPX images with transparency
69da0db 
Handle transparent JPX images, they may contain RGBA data
when no ColorSpace pdf dict is defined or when SMaskInData
is non-zero.

PDF files posted in below issues are fixed by this commit:
https://gitlab.freedesktop.org/poppler/poppler/-/issues/1486
mozilla/pdf.js#16782
mozilla/pdf.js#11306
mozilla/pdf.js#17416

Inspired by related fix in pdf.js:
mozilla/pdf.js#18204

While working on this commit we also succesfully addressed
regressions that emerged for the following files:
mozilla/pdf.js#18896
https://bugs.freedesktop.org/attachment.cgi?id=49294

Issue #1486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
image-jpx
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix decoding of JPX images having an alpha channel calixteman/pdf.js
3 participants
@Snuffleupagus @pubpub-zz @NextThread