Small clean-up of the search related methods in TextLayerBuilder
#10182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
TextLayerBuilder-rm-findController-checks
branch
from
1e6f9e2
to
46d3b01
Compare
This patch does four things: - Change the search related methods in `TextLayerBuilder` to be "private", since there're only called from within the class itself now. - Use `const` for local variables not intended to change in the search related methods in `TextLayerBuilder`. - Finally, removes most `this.findController` checks since they are redundant. Note how both `this._convertMatches` and `this._renderMatches` are *only* ever called, from `this._updateMatches`, when `this.findController` is actually defined. Hence there's really no need to repeat those checks all over the place, especially with all the relevant methods now being marked as "private". - Always initialize the `this._pageMatchesLength` property with an empty array, to simplify the code in `TextLayerBuilder`.
Snuffleupagus
force-pushed
the
TextLayerBuilder-rm-findController-checks
branch
from
46d3b01
to
d73a71f
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/c6f7a496856fa02/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/c6f7a496856fa02/output.txt Total script time: 3.04 mins Published |
timvandermeij
approved these changes
Oct 28, 2018
|
Nice clean-up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch does four things:
TextLayerBuilderto be "private", since there're only called from within the class itself now.constfor local variables not intended to change in the search related methods inTextLayerBuilder.this.findControllerchecks since they are redundant. Note how boththis._convertMatchesandthis._renderMatchesare only ever called, fromthis._updateMatches, whenthis.findControlleris actually defined. Hence there's really no need to repeat those checks all over the place, especially with all the relevant methods now being marked as "private".this._pageMatchesLengthproperty with an empty array, to simplify the code inTextLayerBuilder.