Change canvasInRendering to a WeakSet instead of a WeakMap
#10203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note how nowhere in the code `canvasInRendering.get()` is ever called, and that this structure is really only used to store references to `<canvas>` DOM elements. The reason for this being a `WeakMap` is probably because at the time we weren't using `core-js` polyfills yet, and since there already existed a manually implemented `WeakMap` polyfill it was probably simpler to use that.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/baaa32dd4816465/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 1 Live output at: http://54.215.176.217:8877/39730b17a4408ca/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/baaa32dd4816465/output.txt Total script time: 19.15 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/39730b17a4408ca/output.txt Total script time: 24.74 mins
|
timvandermeij
approved these changes
Oct 31, 2018
|
Looks like a better choice to me too. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note how nowhere in the code
canvasInRendering.get()is ever called, and that this structure is really only used to store references to<canvas>DOM elements.The reason for this being a
WeakMapis probably because at the time we weren't usingcore-jspolyfills yet, and since there already existed a manually implementedWeakMappolyfill it was probably simpler to use that.