For repeated 'findagain' operations, attempt to reset the search position if the user has e.g. scrolled in the document (issue 4141) #10217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by (slightly) refactoring the code responsible for calling `PDFFindController._nextMatch` Unfortunately the `PDFFindController.executeCommand` method has now become a bit more complicated than one would like, but hopefully this small change will improve the structure somewhat (especially for subsequent patches).
…need to be re-calculated when a new search operation occurs
…tion if the user has e.g. scrolled in the document (issue 4141) Currently we'll only attempt to start from the current page when a new search is done, however for 'findagain' operations we'll always continue from the last match position. This could easily lead to confusing behaviour if the user has scrolled to a completely different part of the document. In an attempt to improve this somewhat, for repeated 'findagain' operations, we'll instead reset the position to the current page when it's *absolutely* certain that the user has scrolled. Note that this required adding a new `BaseViewer` method, and exposing that through `PDFLinkService`, in order to check if a given page is visible. In an attempt to avoid issues, in custom implementations of `PDFFindController`, the code checks for the existence of the `PDFLinkService.isPageVisible` method *before* using it.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/15d6ee07abea5f4/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/15d6ee07abea5f4/output.txt Total script time: 3.05 mins Published |
timvandermeij
approved these changes
Nov 3, 2018
|
Seems to work just fine. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we'll only attempt to start from the current page when a new search is done, however for 'findagain' operations we'll always continue from the last match position.
This could easily lead to confusing behaviour if the user has scrolled to a completely different part of the document. In an attempt to improve this somewhat, for repeated 'findagain' operations, we'll instead reset the position to the current page when it's absolutely certain that the user has scrolled.
Note that this required adding a new
BaseViewermethod, and exposing that throughPDFLinkService, in order to check if a given page is visible.In an attempt to avoid issues, in custom implementations of
PDFFindController, the code checks for the existence of thePDFLinkService.isPageVisiblemethod before using it.Fixes #4141.