-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert src/core/document.js
to ES6 syntax
#10393
Conversation
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/a8869f65140cca0/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/a8869f65140cca0/output.txt Total script time: 1.63 mins Published |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/1c540fb3b579a1b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/d8d1c74354d7d86/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/1c540fb3b579a1b/output.txt Total script time: 17.70 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/d8d1c74354d7d86/output.txt Total script time: 23.54 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
I've left a couple of minor comments, and would also like to suggest adding /* eslint no-var: error */
to the top of files that you convert to ES6 to prevent future usage of var
.
4e9ac4c
to
d5e5d18
Compare
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/52b0e10b18bd64c/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ac9e4cb833079ca/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/ac9e4cb833079ca/output.txt Total script time: 17.65 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/52b0e10b18bd64c/output.txt Total script time: 23.25 mins
|
The individual commits can be reviewed with the
?w=1
flag.