Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert more files in src/core to ES6 syntax #10422

Merged
merged 2 commits into from
Jan 6, 2019

Conversation

timvandermeij
Copy link
Contributor

@timvandermeij timvandermeij commented Jan 5, 2019

Use the ?w=1 flag during review for a smaller diff.

@timvandermeij
Copy link
Contributor Author

/botio test

@mozilla mozilla deleted a comment from pdfjsbot Jan 5, 2019
@mozilla mozilla deleted a comment from pdfjsbot Jan 5, 2019
@mozilla mozilla deleted a comment from pdfjsbot Jan 5, 2019
@mozilla mozilla deleted a comment from pdfjsbot Jan 5, 2019
@timvandermeij
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Jan 5, 2019

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/68536927ae6638a/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jan 5, 2019

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/8ee537e43f1b8a3/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jan 5, 2019

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/68536927ae6638a/output.txt

Total script time: 17.60 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jan 5, 2019

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/8ee537e43f1b8a3/output.txt

Total script time: 23.58 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/8ee537e43f1b8a3/reftest-analyzer.html#web=eq.log

src/core/arithmetic_decoder.js Outdated Show resolved Hide resolved
…6 syntax

Moreover, include the "no var" ESLint comment to
`src/core/annotation.js` and `src/core/ps_parser.js` since they are
already converted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants