In getVisibleElements, check firstVisibleElementInd rather than numViews before backtracking (PR 10443 follow-up)
#10501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…numViews` before backtracking (PR 10443 follow-up) When `firstVisibleElementInd === 0`, regardless of the number of views, there's no reason to attempt to backtrack at all since it's never possible to find an element before the *first* one anyway.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/82aef113fd1b7ff/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/82aef113fd1b7ff/output.txt Total script time: 1.68 mins Published |
timvandermeij
approved these changes
Jan 27, 2019
|
Makes sense. Thanks! |
Snuffleupagus
deleted the
getVisibleElements-avoid-unnecessary-backtrack
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
firstVisibleElementInd === 0, regardless of the number of views, there's no reason to attempt to backtrack at all since it's never possible to find an element before the first one anyway.