Add a special gulp xfatest command, to limit the ref-tests to only XFA-documents (issue 13744)
#13846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
changed the title
gulp test-xfa command, to limit the ref-tests to only XFA-documents (issue 13744)gulp xfatest command, to limit the ref-tests to only XFA-documents (issue 13744)
Snuffleupagus
added a commit
to Snuffleupagus/botio-files-pdfjs
that referenced
this pull request
Aug 3, 2021
Snuffleupagus
added a commit
to Snuffleupagus/botio-files-pdfjs
that referenced
this pull request
Aug 3, 2021
…XFA-documents (issue 13744) The new command is a *variation* of the standard `gulp test` command and will run all unit/font/integration-tests just as normal, while *only* running ref-tests for XFA-documents to speed up development. Given that we currently have (some) unit-tests for XFA-documents, and that we may also (in the future) want to add integration-tests, it thus makes sense to run all test-suites in my opinion. *Please note:* Once this patch has landed, I'll submit a follow-up patch to https://github.com/mozilla/botio-files-pdfjs such that we can also run the new command on the bots.
timvandermeij
approved these changes
Aug 3, 2021
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new command is a variation of the standard
gulp testcommand and will run all unit/font/integration-tests just as normal, while only running ref-tests for XFA-documents to speed up development.Given that we currently have (some) unit-tests for XFA-documents, and that we may also (in the future) want to add integration-tests, it thus makes sense to run all test-suites in my opinion.
Please note: Once this patch has landed, I'll submit a follow-up patch to https://github.com/mozilla/botio-files-pdfjs such that we can also run the new command on the bots.