Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XFA - Page can be too small when printing (bug 1723705) #13852

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman
Copy link
Contributor Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Aug 3, 2021

From: Bot.io (Linux m4)


Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/228153ff9ec05a9/output.txt

@marco-c
Copy link
Contributor

marco-c commented Aug 3, 2021

Can you add a test?

@pdfjsbot
Copy link

pdfjsbot commented Aug 3, 2021

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/228153ff9ec05a9/output.txt

Total script time: 5.57 mins

Published

@calixteman
Copy link
Contributor Author

Unfortunately, I think we don't have such tests for now.
I filed a bug: #13853

@marco-c
Copy link
Contributor

marco-c commented Aug 3, 2021

Unfortunately, I think we don't have such tests for now.

What does setting "print: true" in test_manifest.json do then?

@calixteman
Copy link
Contributor Author

Some data are picked up in the annotation storage in order to be used as values for some text fields, checkboxes, ... (depending on the id).

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Aug 3, 2021

What does setting "print: true" in test_manifest.json do then?

It tests only the rendering pipeline of the PDF.js library, by using the correct intent and placing Annotation-data on the canvas itself, but doesn't actually test the complete printing process as it happens in the browser.

@calixteman calixteman merged commit 0b95d69 into mozilla:master Aug 3, 2021
@calixteman calixteman deleted the xfa_print_1 branch August 3, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants