Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent breaking errors when an optional content group is undefined (issue 13851) #13854

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

Snuffleupagus
Copy link
Collaborator

In the referenced PDF document most of the form /Form XObjects don't have an /OC entry, which thus causes the runtime failure during rendering.

Fixes #13851

…issue 13851)

In the referenced PDF document *most* of the form `/Form` XObjects don't have an `/OC` entry, which thus causes the runtime failure during rendering.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Aug 3, 2021

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/f0abf47a2c100b7/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 3, 2021

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://3.101.106.178:8877/309c7c42aab26f2/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 3, 2021

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/f0abf47a2c100b7/output.txt

Total script time: 33.42 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 5
  different first/second rendering: 1

Image differences available at: http://54.67.70.0:8877/f0abf47a2c100b7/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Aug 3, 2021

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/309c7c42aab26f2/output.txt

Total script time: 39.13 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 8
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/309c7c42aab26f2/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Aug 3, 2021

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/7c5b81635f9749d/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 3, 2021

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/7c5b81635f9749d/output.txt

Total script time: 5.70 mins

Published

@timvandermeij timvandermeij merged commit 85be62c into mozilla:master Aug 3, 2021
@timvandermeij
Copy link
Contributor

Thanks for fixing this!

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Aug 3, 2021

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/c29cd8503813601/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 3, 2021

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 1

Live output at: http://3.101.106.178:8877/dea77efbd313233/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 3, 2021

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/c29cd8503813601/output.txt

Total script time: 30.38 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Aug 3, 2021

From: Bot.io (Windows)


Success

Full output at http://3.101.106.178:8877/dea77efbd313233/output.txt

Total script time: 36.83 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the issue-13851 branch August 3, 2021 22:17
@ypersion1956
Copy link

Than you for fixing the issue. Since the release is not expected soon, and my client grows impatient, what woudl be possible steps to modify the document to make it workable?
The issue was missing /OC in some groups. How can this be fixed by editing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Null pointer exception in optional_content_config.js when viewing PDF document
4 participants