Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the PDFViewerApplication.supportsFullscreen getter #13940

Merged
merged 2 commits into from
Aug 27, 2021
Merged

Simplify the PDFViewerApplication.supportsFullscreen getter #13940

merged 2 commits into from
Aug 27, 2021

Commits on Aug 27, 2021

  1. Use optional chaining even more in the web/app.js file

    @Snuffleupagus
    Snuffleupagus committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    8ff0f8e View commit details
    Browse the repository at this point in the history

  2. Simplify the PDFViewerApplication.supportsFullscreen getter 

    A lot of the code in this getter has existed ever since the initial PresentationMode-implementation was first added all the way back in PR 1938 (which is nine years ago now).
At this point in time however, there's now a simpler way detect if a browser supports the FullScreen API and we should thus be able to simplify this getter; please refer to https://developer.mozilla.org/en-US/docs/Web/API/Document/fullscreenEnabled#browser_compatibility
    @Snuffleupagus
    Snuffleupagus committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    bc2bb18 View commit details
    Browse the repository at this point in the history