Ensure that PasswordException is handled correctly in the wrapReason function
#13941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/daa19e6695d7f90/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/cfb6af6642f6c5e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/cfb6af6642f6c5e/output.txt Total script time: 3.85 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/daa19e6695d7f90/output.txt Total script time: 6.36 mins
|
…on` function While running the unit-tests with some logging statements added to this code, I noticed that `PasswordException` was missing from the list of potential Errors that could be passed to the `wrapReason` function.
Snuffleupagus
changed the title
PasswordException in handled correctly in the wrapReason functionPasswordException is handled correctly in the wrapReason function
Snuffleupagus
force-pushed
the
MessageHandler-PasswordException
branch
from
ba10023
to
9ea3fa0
Compare
timvandermeij
approved these changes
Aug 29, 2021
|
Nice find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running the unit-tests with some logging statements added to this code, I noticed that
PasswordExceptionwas missing from the list of potential Errors that could be passed to thewrapReasonfunction.