XFA - Overwrite AcroForm dictionary when saving if no datasets in XFA (bug 1720179) #13967
Conversation
| let xfaDatasets = null; | ||
| let hasDatasets = false; |
There was a problem hiding this comment.
Do you actually need this separate boolean?
Can't you just check !!xfaDatasets in the src/core/writer.js code, and thus avoid the need to track closely related state twice?
There was a problem hiding this comment.
In case xfaDatasets is null, I set it to a new reference after having visited the XFA array so it's no more null.
So the only way for xfaDatasets to be null is to not have an array for XFA.
So when we have an array we must know if the reference we've has been newly created (and in this case we must update AcroForm) or not.
We could probably get rid of this boolean in moving https://github.com/mozilla/pdf.js/blob/master/src/core/worker.js#L650 in writer.js because the afaik the xref for the xref table must be the last one (so it's why I get the new ref for xfaDatasets before calling incrementalUpdate), but I guess it's better to do that in a follow-up.
… (bug 1720179) - aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1720179 - in some pdfs the XFA array in AcroForm dictionary doesn't contain an entry for 'datasets' (which contains saved data), so basically this patch allows to overwrite the AcroForm dictionary with an updated XFA array when doing an incremental update.
calixteman
force-pushed
the
no_datasets
branch
from
8569e6f
to
77b9657
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @brendandahl received. Current queue size: 0 Live output at: http://54.241.84.105:8877/399d63079302a73/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @brendandahl received. Current queue size: 0 Live output at: http://54.193.163.58:8877/7ac1125b782d505/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/399d63079302a73/output.txt Total script time: 2.88 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/7ac1125b782d505/output.txt Total script time: 5.76 mins
|
In fixing this bug I found another one: #13966 and with both fix we can save the form in the above bug and opening it in Acrobat.