-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotation - For checkboxes, get field value from AS (if any) instead of V (bug 1722036) #14035
Conversation
calixteman
commented
Sep 17, 2021
- it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1722036.
- AS and V should share the same value for checkbox: it's at least what the specs say;
- the pdf in the above bug opens correctly in Acrobat so it likely means that AS is chosen over V.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, with the comments addressed and all tests passing; thank you!
… of V (bug 1722036) - it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1722036. - AS and V should share the same value for checkbox: it's at least what the specs say; - the pdf in the above bug opens correctly in Acrobat so it likely means that AS is chosen over V.
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/221930f80801f84/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/c51d4977d920b8e/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/221930f80801f84/output.txt Total script time: 21.66 mins
Image differences available at: http://54.241.84.105:8877/221930f80801f84/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/c51d4977d920b8e/output.txt Total script time: 39.64 mins
Image differences available at: http://54.193.163.58:8877/c51d4977d920b8e/reftest-analyzer.html#web=eq.log |
It seems that we had a font rendering issue in last makeref: |
I don't think it's our "fault", since this looks like (yet) another case where some font rendering changes were made in Firefox itself. As far as I'm concerned, I think you can ignore those "regressions" and simply land this PR and run makeref. |
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7b0d95fcaa8f003/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a372bf05e5e50af/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/7b0d95fcaa8f003/output.txt Total script time: 17.98 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/a372bf05e5e50af/output.txt Total script time: 37.11 mins
|
/botio-linux makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4cc611e7d178f0b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/4cc611e7d178f0b/output.txt Total script time: 19.62 mins
|