Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dialogs with forced colors (bug 1722984) #14042

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Fix dialogs with forced colors (bug 1722984) #14042

merged 1 commit into from
Sep 24, 2021

Conversation

serdnab
Copy link
Contributor

@serdnab serdnab commented Sep 17, 2021

Fix for #13872.
When forced colors are set, this variable is set to use the system buttontext color, preventing the use of the color set in the color settings.
This assignment can be removed since the colors of the html elements that use this variable are overwritten by the browser when the forced colors are set.

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/16462d4b46fd2ae/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/16462d4b46fd2ae/output.txt

Total script time: 4.17 mins

Published

@timvandermeij
Copy link
Contributor

/cc @brendandahl @utopianknight Could you check if this is correct and working as expected?

@brendandahl
Copy link
Contributor

Look good, thank you!

@brendandahl brendandahl changed the title document info correct colors Fix dialogs with forced colors (bug 1722984) Sep 24, 2021
@brendandahl brendandahl merged commit c3ca78f into mozilla:master Sep 24, 2021
@timvandermeij timvandermeij removed the request for review from brendandahl September 25, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants