Commits on Sep 26, 2021

1. [api-minor] Move the addDefaultProtocolToUrl/`tryConvertUrlEncoding… …

   …` functionality into the `createValidAbsoluteUrl` function
   
   Having recently worked with, and reviewed patches touching, this code it seemed that it's probably not a bad idea to move that functionality into `createValidAbsoluteUrl` as new options instead.
   
   For the `addDefaultProtocolToUrl` functionality in particular, the existing helper function was not only moved but slightly improved as well. Looking at the code, I realized that there's a small risk that it would incorrectly match a *relative* URL-string too.
   
   With these changes, the `createValidAbsoluteUrl` call-sites in the `src/core/`-code can be simplified a little bit.
   
   *Please note:* This patch may, indirectly, change the format of the `unsafeUrl`-property returned with relevant Annotations and OutlineItems; hence the `api-minor` tag.
   However, I'd argue that it's actually more correct this way since the whole purpose of `unsafeUrl` is/was to return the URL data as-is without any parsing done.

   

   Snuffleupagus committed Sep 26, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for e6e0469
   • Browse repository at this point

   Copy the full SHA

   e6e0469 View commit details

   Browse the repository at this point in the history