Prevent double-rendering borders for PushButton-annotations (PR 14083 follow-up) #14174
Conversation
… follow-up) With ResetForm-action support added in PR 14083, there's a regression in the `issue12716` test-case. More specifically the border around the "Clear Form"-link is now rendered *twice*, once in the canvas via the appearance-stream and once in the annotationLayer via the border-data. This looks slightly weird, and was most likely not intended, which is why this patch suggests that we ignore the border in the annotationLayer when an appearance-stream exists.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0f405531ecae7e2/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/0f405531ecae7e2/output.txt Total script time: 4.32 mins Published |
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5b9443698769e4d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/8cc94272750dbd0/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/5b9443698769e4d/output.txt Total script time: 19.50 mins
Image differences available at: http://54.241.84.105:8877/5b9443698769e4d/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/8cc94272750dbd0/output.txt Total script time: 37.03 mins
Image differences available at: http://54.193.163.58:8877/8cc94272750dbd0/reftest-analyzer.html#web=eq.log |
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/48b57780a6cd5cc/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/dcf189c40cee3f1/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/48b57780a6cd5cc/output.txt Total script time: 20.26 mins
|
|
/botio-windows makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/f95e4b2d9fa0b29/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/dcf189c40cee3f1/output.txt Total script time: 31.74 mins
|
|
/botio-windows makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/7e0accfa4fc89d6/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/f95e4b2d9fa0b29/output.txt Total script time: 30.52 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/7e0accfa4fc89d6/output.txt Total script time: 37.87 mins
|
With ResetForm-action support added in PR #14083, there's a regression in the
issue12716test-case. More specifically the border around the "Clear Form"-link is now rendered twice, once in the canvas via the appearance-stream and once in the annotationLayer via the border-data.This looks slightly weird, and was most likely not intended, which is why this patch suggests that we ignore the border in the annotationLayer when an appearance-stream exists.