Add the font Linux Libertine as a possible substitution for Times New Roman #17405

calixteman · 2023-12-10T21:14:33Z

and try to load the font family (guessed from the font name) before trying
the local substitution.
The local(...) command expects to have a real font name and not a predefined
substitution it's why we try the font family.

Snuffleupagus · 2023-12-10T21:19:57Z

I'm guessing that this patch is related to issue #17401? If so, can you please get the user to confirm that it fixes the problem?

/botio-linux preview

moz-tools-bot · 2023-12-10T21:19:59Z

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/70ae51edc48ebfe/output.txt

moz-tools-bot · 2023-12-10T21:21:28Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/70ae51edc48ebfe/output.txt

Total script time: 1.46 mins

Published

Viewer: http://54.241.84.105:8877/70ae51edc48ebfe/web/viewer.html
Viewer (legacy): http://54.241.84.105:8877/70ae51edc48ebfe/legacy/web/viewer.html

jwillia3 · 2023-12-11T21:14:52Z

On both Viewer and Legacy Viewer, Nimbus Roman is selected. (See screenshot)

Nimbus Roman is still being selected and displayed even when fontconfig excludes the font and even when the files are deleted from the system.

It is now selecting Nimbus Roman over DejaVu Serif, but I can't find a way to get Linux Libertine O to be selected. Also note, people may have Linux Libertine installed and not Linux Libertine O.

Re: DejaVu Serif, would it also not be good to remove that from the list since it is not metric compatible?

calixteman · 2024-01-14T20:52:22Z

/botio-linux preview

moz-tools-bot · 2024-01-14T20:52:25Z

From: Bot.io (Linux m4)

Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/91c07af1ae6be73/output.txt

moz-tools-bot · 2024-01-14T20:53:51Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/91c07af1ae6be73/output.txt

Total script time: 1.42 mins

Published

Viewer: http://54.241.84.105:8877/91c07af1ae6be73/web/viewer.html
Viewer (legacy): http://54.241.84.105:8877/91c07af1ae6be73/legacy/web/viewer.html

calixteman · 2024-01-14T21:00:44Z

@jwillia3 could you try again with the viewer in #17405 (comment) ?

jwillia3 · 2024-01-15T09:03:21Z

It seems like it's using Nimbus Roman no matter what fonts I have installed.

It does not select Linux Libertine when available even when Nimbus Roman is not installed.

I tried removed all fonts (including Nimbus Roman) except for the list below and it still selected Nimbus Roman.

luximr.ttf: "Luxi Mono" "Regular"
luxirr.ttf: "Luxi Serif" "Regular"
luxisr.ttf: "Luxi Sans" "Regular"
c0419bt_.pfb: "Courier 10 Pitch" "Regular"
UTRG____.pfa: "Utopia" "Regular"
l048013t.pfa: "Luxi Sans" "Regular"
c0648bt_.pfb: "Bitstream Charter" "Regular"
l049013t.pfa: "Luxi Serif" "Regular"
l047013t.pfa: "Luxi Mono" "Regular"
cour.pfa: "Courier" "Regular"
luxirb.ttf: "Luxi Serif" "Bold"
luxisb.ttf: "Luxi Sans" "Bold"
luximb.ttf: "Luxi Mono" "Bold"
courb.pfa: "Courier" "Bold"
UTB_____.pfa: "Utopia" "Bold"
c0583bt_.pfb: "Courier 10 Pitch" "Bold"
c0632bt_.pfb: "Bitstream Charter" "Bold"
l047016t.pfa: "Luxi Mono" "Bold"
l048016t.pfa: "Luxi Sans" "Bold"
l049016t.pfa: "Luxi Serif" "Bold"
UTI_____.pfa: "Utopia" "Italic"
c0582bt_.pfb: "Courier 10 Pitch" "Italic"
c0649bt_.pfb: "Bitstream Charter" "Italic"
couri.pfa: "Courier" "Italic"
courbi.pfa: "Courier" "Bold Italic"
UTBI____.pfa: "Utopia" "Bold Italic"
c0611bt_.pfb: "Courier 10 Pitch" "Bold Italic"
c0633bt_.pfb: "Bitstream Charter" "Bold Italic"
luxirri.ttf: "Luxi Serif" "Oblique"
luxisri.ttf: "Luxi Sans" "Oblique"
luximri.ttf: "Luxi Mono" "Oblique"
l047033t.pfa: "Luxi Mono" "Oblique"
l049033t.pfa: "Luxi Serif" "Oblique"
l048033t.pfa: "Luxi Sans" "Oblique"
luximbi.ttf: "Luxi Mono" "Bold Oblique"
luxirbi.ttf: "Luxi Serif" "Bold Oblique"
luxisbi.ttf: "Luxi Sans" "Bold Oblique"
l049036t.pfa: "Luxi Serif" "Bold Oblique"
l047036t.pfa: "Luxi Mono" "Bold Oblique"
l048036t.pfa: "Luxi Sans" "Bold Oblique"

calixteman · 2024-01-15T09:40:21Z

@jwillia3, what is the screenshot supposed to show ?
The tracemonkey.pdf file embeds all its fonts so it can't be used as a test case.
You should open the unix manual as in #17401 (comment) and see if the font used to render the page is the correct one.
If you're talking about the font used in the UI then it's another thing.

jwillia3 · 2024-01-15T14:49:13Z

OK.
I didn't know you could change the preview file.
I still get Bitstream Vera Serif preferentially.

These are the steps I took.

I download http://harmful.cat-v.org/cat-v/unix_prog_design.pdf.
Open http://54.241.84.105:8877/91c07af1ae6be73/web/viewer.html
Click the ">>" menu and select Open
Open my downloaded copy of unix_prog_design.pdf
See Bitstream Vera Serif is used
Closed Firefox
Add the following to fontconfig to disable Bitstream Vera Serif

<selectfont>
  <rejectfont>
    <glob>/usr/local/share/fonts/dejavu/*</glob>
  </rejectfont>
</selectfont>

Repeat steps 1, 2, 3, and 4
See Linux Libertine used

calixteman · 2024-01-15T20:14:36Z

/botio-linux preview

moz-tools-bot · 2024-01-15T20:14:49Z

From: Bot.io (Linux m4)

Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6263f2224aa9467/output.txt

moz-tools-bot · 2024-01-15T20:16:15Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/6263f2224aa9467/output.txt

Total script time: 1.42 mins

Published

Viewer: http://54.241.84.105:8877/6263f2224aa9467/web/viewer.html
Viewer (legacy): http://54.241.84.105:8877/6263f2224aa9467/legacy/web/viewer.html

calixteman · 2024-01-15T20:30:03Z

@jwillia3, could you try again please ?

jwillia3 · 2024-01-15T20:34:19Z

@calixteman Looks good. Thanks for looking into this.

Snuffleupagus

This patch now does "a bunch" more than just adding a few new font-substitutions, so can you please extend the commit message to mention/explain the other changes?

Also, please run all tests!

src/core/font_substitutions.js

… Roman and try to load the font family (guessed from the font name) before trying the local substitution. The local(...) command expects to have a real font name and not a predefined substitution it's why we try the font family.

calixteman · 2024-01-16T11:32:27Z

/botio test

moz-tools-bot · 2024-01-16T11:32:30Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1a217d36afc94ad/output.txt

moz-tools-bot · 2024-01-16T11:32:30Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/052730f4a13c7b4/output.txt

moz-tools-bot · 2024-01-16T11:56:56Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/1a217d36afc94ad/output.txt

Total script time: 24.42 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 269
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/1a217d36afc94ad/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2024-01-16T12:10:30Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/052730f4a13c7b4/output.txt

Total script time: 37.99 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 18
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/052730f4a13c7b4/reftest-analyzer.html#web=eq.log

calixteman · 2024-01-16T12:45:49Z

The differences in the with the linux tests are expected since we now use a substitution as defined with in fontconfig files and not the ones we defined ourselves.

Snuffleupagus

I've tried looking through all of the Linux "failures", and as far as I can tell there's only small/expected movement however nothing seems outright broken.

r=me, thank you!

calixteman · 2024-01-16T13:32:38Z

/botio makeref

moz-tools-bot · 2024-01-16T13:32:41Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ce93b34f364eb04/output.txt

moz-tools-bot · 2024-01-16T13:32:41Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a0a3a8188d0fa19/output.txt

Snuffleupagus · 2024-01-16T13:38:32Z

@calixteman Once this reaches mozilla-central, we should check if it also fixes bug 1839860.

moz-tools-bot · 2024-01-16T13:51:19Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/ce93b34f364eb04/output.txt

Total script time: 18.62 mins

Lint: Passed
Make references: Passed
Check references: Passed

moz-tools-bot · 2024-01-16T13:59:36Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/a0a3a8188d0fa19/output.txt

Total script time: 26.90 mins

Lint: Passed
Make references: Passed
Check references: Passed

calixteman added the font-conversion label Dec 10, 2023

calixteman requested a review from Snuffleupagus December 10, 2023 21:14

calixteman mentioned this pull request Dec 11, 2023

Poor Quality Font Substitution #17401

Closed

calixteman force-pushed the libertine branch from 5ad5162 to 3dc8bf1 Compare January 14, 2024 20:52

calixteman force-pushed the libertine branch from 3dc8bf1 to da62e52 Compare January 14, 2024 21:27

calixteman force-pushed the libertine branch from da62e52 to 7523499 Compare January 15, 2024 20:12

Snuffleupagus reviewed Jan 16, 2024

View reviewed changes

Snuffleupagus linked an issue Jan 16, 2024 that may be closed by this pull request

Poor Quality Font Substitution #17401

Closed

Snuffleupagus reviewed Jan 16, 2024

View reviewed changes

src/core/font_substitutions.js Outdated Show resolved Hide resolved

calixteman force-pushed the libertine branch from 7523499 to fb6be0f Compare January 16, 2024 11:31

calixteman force-pushed the libertine branch from fb6be0f to 10389c5 Compare January 16, 2024 11:32

Snuffleupagus approved these changes Jan 16, 2024

View reviewed changes

calixteman merged commit e7d782e into mozilla:master Jan 16, 2024
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add the font Linux Libertine as a possible substitution for Times New Roman #17405

Add the font Linux Libertine as a possible substitution for Times New Roman #17405

calixteman commented Dec 10, 2023 •

edited

Loading

Snuffleupagus commented Dec 10, 2023

moz-tools-bot commented Dec 10, 2023

moz-tools-bot commented Dec 10, 2023

jwillia3 commented Dec 11, 2023

calixteman commented Jan 14, 2024

moz-tools-bot commented Jan 14, 2024

moz-tools-bot commented Jan 14, 2024

calixteman commented Jan 14, 2024

jwillia3 commented Jan 15, 2024

calixteman commented Jan 15, 2024

jwillia3 commented Jan 15, 2024

calixteman commented Jan 15, 2024

moz-tools-bot commented Jan 15, 2024

moz-tools-bot commented Jan 15, 2024

calixteman commented Jan 15, 2024

jwillia3 commented Jan 15, 2024

Snuffleupagus left a comment

calixteman commented Jan 16, 2024

moz-tools-bot commented Jan 16, 2024

moz-tools-bot commented Jan 16, 2024

moz-tools-bot commented Jan 16, 2024

moz-tools-bot commented Jan 16, 2024

calixteman commented Jan 16, 2024

Snuffleupagus left a comment

calixteman commented Jan 16, 2024

moz-tools-bot commented Jan 16, 2024

moz-tools-bot commented Jan 16, 2024

Snuffleupagus commented Jan 16, 2024 •

edited

Loading

moz-tools-bot commented Jan 16, 2024

moz-tools-bot commented Jan 16, 2024

Add the font Linux Libertine as a possible substitution for Times New Roman #17405

Add the font Linux Libertine as a possible substitution for Times New Roman #17405

Conversation

calixteman commented Dec 10, 2023 • edited Loading

Snuffleupagus commented Dec 10, 2023

moz-tools-bot commented Dec 10, 2023

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Dec 10, 2023

From: Bot.io (Linux m4)

Success

Published

jwillia3 commented Dec 11, 2023

calixteman commented Jan 14, 2024

moz-tools-bot commented Jan 14, 2024

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Jan 14, 2024

From: Bot.io (Linux m4)

Success

Published

calixteman commented Jan 14, 2024

jwillia3 commented Jan 15, 2024

calixteman commented Jan 15, 2024

jwillia3 commented Jan 15, 2024

calixteman commented Jan 15, 2024

moz-tools-bot commented Jan 15, 2024

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Jan 15, 2024

From: Bot.io (Linux m4)

Success

Published

calixteman commented Jan 15, 2024

jwillia3 commented Jan 15, 2024

Snuffleupagus left a comment

Choose a reason for hiding this comment

calixteman commented Jan 16, 2024

moz-tools-bot commented Jan 16, 2024

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Jan 16, 2024

From: Bot.io (Windows)

Received

moz-tools-bot commented Jan 16, 2024

From: Bot.io (Linux m4)

Failed

moz-tools-bot commented Jan 16, 2024

From: Bot.io (Windows)

Failed

calixteman commented Jan 16, 2024

Snuffleupagus left a comment

Choose a reason for hiding this comment

calixteman commented Jan 16, 2024

moz-tools-bot commented Jan 16, 2024

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Jan 16, 2024

From: Bot.io (Windows)

Received

Snuffleupagus commented Jan 16, 2024 • edited Loading

moz-tools-bot commented Jan 16, 2024

From: Bot.io (Linux m4)

Success

moz-tools-bot commented Jan 16, 2024

From: Bot.io (Windows)

Success

calixteman commented Dec 10, 2023 •

edited

Loading

Snuffleupagus commented Jan 16, 2024 •

edited

Loading