Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take into account empty lines when extracting text content from the appearance #17512

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Take into account empty lines when extracting text content from the appearance #17512

merged 1 commit into from
Jan 15, 2024

Conversation

calixteman
Copy link
Contributor

Fixes #17492.

Snuffleupagus
Snuffleupagus approved these changes Jan 14, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's even simpler than I imagined :-)

r=me, with all tests passing; thank you!

test/unit/api_spec.js Outdated Show resolved Hide resolved
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d15d9756f45e915/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c7d7228cdd9244a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/d15d9756f45e915/output.txt

Total script time: 24.47 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 17

Image differences available at: http://54.241.84.105:8877/d15d9756f45e915/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/c7d7228cdd9244a/output.txt

Total script time: 29.90 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 25

Image differences available at: http://54.193.163.58:8877/c7d7228cdd9244a/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

The failure with bug1219400.pdf is an improvement (there's an empty line in the FreeText annotation).

@calixteman
Copy link
Contributor Author

/botio-windows integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c5b95ed71368b7c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/c5b95ed71368b7c/output.txt

Total script time: 15.70 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 2ca20de into mozilla:master Jan 15, 2024
9 checks passed
@calixteman
Copy link
Contributor Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/54969c605fc3eb2/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/dce6f9463d5c841/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/54969c605fc3eb2/output.txt

Total script time: 18.62 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/dce6f9463d5c841/output.txt

Total script time: 26.33 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@calixteman calixteman deleted the issue17492 branch January 15, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
form-acroform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extra line breaks are missing when PDF is loaded
3 participants
@calixteman @moz-tools-bot @Snuffleupagus