Remove DNS resolver workaround from the test framework #17547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `if` statement is no longer necessary because the Node.js versions that didn't provide `dns.setDefaultResultOrder` are no longer supported, but looking into this a bit more it turns out that the entire workaround is no longer necessary because the issue got fixed in Firefox 105 in bug 1769994. Indeed, Firefox now starts nicely with the workaround removed. Reverts 60ed3cd.
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5ae745bf0e09948/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/09df4541ad8b3f8/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/5ae745bf0e09948/output.txt Total script time: 2.44 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/09df4541ad8b3f8/output.txt Total script time: 8.08 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ifstatement is no longer necessary because the Node.js versions that didn't providedns.setDefaultResultOrderare no longer supported, but looking into this a bit more it turns out that the entire workaround is no longer necessary because the issue got fixed in Firefox 105 in bug 1769994. Indeed, Firefox now starts nicely with the workaround removed.Reverts 60ed3cd.