Ensure that GenericL10n works if the locale files cannot be loaded
#17603
Conversation
Snuffleupagus
force-pushed
the
GenericL10n-fallback
branch
from
12b1252
to
23ddf63
Compare
Snuffleupagus
force-pushed
the
GenericL10n-fallback
branch
from
23ddf63
to
7d95b99
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/fb29af72e23a0ae/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/71b26d5d03decd4/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/fb29af72e23a0ae/output.txt Total script time: 24.75 mins
Image differences available at: http://54.241.84.105:8877/fb29af72e23a0ae/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/71b26d5d03decd4/output.txt Total script time: 41.78 mins
Image differences available at: http://54.193.163.58:8877/71b26d5d03decd4/reftest-analyzer.html#web=eq.log |
- Ensure that localization works in the GENERIC viewer, even if the necessary locale files cannot be loaded. This was the behaviour prior to the introduction of Fluent, and it seems worthwhile to keep that (especially since we already bundle the en-US strings anyway). - Let the `GenericL10n`-implementation use the *bundled* en-US strings directly when no language is provided. - Remove the `NullL10n`-implementation, and simply fallback to `GenericL10n`, to reduce the maintenance burden of viewer-components localization. - Indirectly, given the previous point, stop exporting `NullL10n` in the viewer-components since it's now removed. Note that it was never really intended to be used directly and only existed as a fallback. *Please note:* This doesn't affect the Firefox PDF Viewer, thanks to the use of import maps.
Snuffleupagus
force-pushed
the
GenericL10n-fallback
branch
from
7d95b99
to
97c2ce9
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f610faa8a4a59de/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/f610faa8a4a59de/output.txt Total script time: 1.23 mins Published |
Ensure that localization works in the GENERIC viewer, even if the necessary locale files cannot be loaded.
This was the behaviour prior to the introduction of Fluent, and it seems worthwhile to keep that (especially since we already bundle the en-US strings anyway).
Let the
GenericL10n-implementation use the bundled en-US strings directly when no language is provided.Remove the
NullL10n-implementation, and simply fallback toGenericL10n, to reduce the maintenance burden of viewer-components localization.Indirectly, given the previous point, stop exporting
NullL10nin the viewer-components since it's now removed.Note that it was never really intended to be used directly and only existed as a fallback.
Please note: This doesn't affect the Firefox PDF Viewer, thanks to the use of import maps.