Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove empty, top-level, nodes in the Babel plugin #17647

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Remove empty, top-level, nodes in the Babel plugin #17647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions external/builder/babel-plugin-pdfjs-preprocessor.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,13 @@ function babelPluginPDFJSPreprocessor(babel, ctx) {
if (t.isBooleanLiteral(node.test)) {
// if (true) stmt1; => stmt1
// if (false) stmt1; else stmt2; => stmt2
path.replaceWith(
node.test.value === true
? node.consequent
: node.alternate || t.emptyStatement()
);
if (node.test.value === true) {
path.replaceWith(node.consequent);
} else if (node.alternate) {
path.replaceWith(node.alternate);
} else {
path.remove(node);
}
}
},
},
Expand Down
5 changes: 3 additions & 2 deletions external/builder/fixtures_esprima/ifs-expected.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,12 @@
{
"1";
}
;
{
"2";
}
;
if ('1') {
"1";
}
function f1() {
Dismissed Show dismissed Hide dismissed
"1";
Dismissed Show dismissed Hide dismissed
}
9 changes: 9 additions & 0 deletions external/builder/fixtures_esprima/ifs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,12 @@
if (true && false || '1') {
"1";
}

function f1() {
Dismissed Show dismissed Hide dismissed
if (true) {
"1";
Dismissed Show dismissed Hide dismissed
}
if (false) {
Dismissed Show dismissed Hide dismissed
"2";
Dismissed Show dismissed Hide dismissed
}
}