Modernize the webserver code (part 1) #17661
Conversation
The `handler` method contained this code in an inline function, which made the `handler` method big and harder to read. Moreover, this code relied on variables from the outer scope, which made it harder to reason about because the inputs and outputs weren't easily visible. This commit fixes the problems by extracting the file serving code into a dedicated private method, and modernizing it to use e.g. `const`/`let` instead of `var` and using template strings.
The `handler` method contained this code in an inline function, which made the `handler` method big and harder to read. Moreover, this code relied on variables from the outer scope, which made it harder to reason about because the inputs and outputs weren't easily visible. This commit fixes the problems by extracting the range file serving code into a dedicated private method, and modernizing it to use e.g. `const`/ `let` instead of `var` and using template strings.
timvandermeij
force-pushed
the
modernize-webserver
branch
from
af57642
to
935e8c8
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
The changes since the original commits are easiest to view with the interdiff in no-whitespace mode: https://github.com/mozilla/pdf.js/compare/af5764273b29b2e34ead0b54bfefe3ca912fedd1..935e8c8c5bec6cb1e36d8976780ca2d61e9118f2?w=1. I made the following changes:
|
timvandermeij
force-pushed
the
modernize-webserver
branch
from
935e8c8
to
d893f17
Compare
The `handler` method contained this code in an inline function, which made the `handler` method big and harder to read. Moreover, this code relied on variables from the outer scope, which made it harder to reason about because the inputs and outputs weren't easily visible. This commit fixes the problems by extracting the directory listing code into a dedicated private method, and modernizing it to use e.g. `const`/ `let` instead of `var` and using template strings.
timvandermeij
force-pushed
the
modernize-webserver
branch
from
d893f17
to
ce4fe0c
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/46d9eddfe1f86c7/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/69b208165afe520/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/46d9eddfe1f86c7/output.txt Total script time: 24.67 mins
Image differences available at: http://54.241.84.105:8877/46d9eddfe1f86c7/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/69b208165afe520/output.txt Total script time: 41.61 mins
Image differences available at: http://54.193.163.58:8877/69b208165afe520/reftest-analyzer.html#web=eq.log |
The commit messages contain more details about the individual changes. This first part mainly focuses on extracting self-contained functionality from the large
handlermethod to make it more manageable and to get rid of using variables from the outer scope (with the end goal of enabling theno-varrule for this file).The first and last commits should be reviewed with the
?w=1flag for an easier diff.