Move the alias-building out of the createWebpackConfig function
#17691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Over time, as we've started relying more and more on import maps, the number of aliases have increased a lot. This is now affecting the size and readability of `createWebpackConfig`, which was already fairly large and complex, hence moving the aliases to their own function should help improve things a little bit.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ade682f4cbde7f6/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/469d18e302bb3b8/output.txt |
nicolo-ribaudo
approved these changes
Feb 19, 2024
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/469d18e302bb3b8/output.txt Total script time: 24.79 mins
Image differences available at: http://54.241.84.105:8877/469d18e302bb3b8/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/ade682f4cbde7f6/output.txt Total script time: 39.07 mins
Image differences available at: http://54.193.163.58:8877/ade682f4cbde7f6/reftest-analyzer.html#web=eq.log |
Snuffleupagus
requested review from
calixteman
and removed request for
calixteman
|
@calixteman Gentle review ping? |
timvandermeij
approved these changes
Mar 20, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the
alias-building out of thecreateWebpackConfigfunctionOver time, as we've started relying more and more on import maps, the number of aliases have increased a lot. This is now affecting the size and readability of
createWebpackConfig, which was already fairly large and complex, hence moving the aliases to their own function should help improve things a little bit.Use more optional chaining, and other modern JS, in the building code