Add better validation for the "PREFERENCE" kind AppOptions
#17694
Conversation
Snuffleupagus
force-pushed
the
validate-defaultOptions
branch
2 times, most recently
from
885bc96
to
64ca88f
Compare
|
/botio unittest |
Snuffleupagus
force-pushed
the
validate-defaultOptions
branch
2 times, most recently
from
54ef398
to
3d38e09
Compare
Given that the "PREFERENCE" kind is used e.g. to generate the preference-list for the Firefox PDF Viewer, those options need to be carefully validated. With this patch we'll now check this unconditionally in development mode, during testing, and when creating the preferences in the gulpfile.
Previously we'd simply export this directly from `web/app_options.js`, which meant that it'd be technically possible to *accidentally* modify the `compatibilityParams` Object when accessing it. To avoid this we instead introduce a new `AppOptions`-method that is used to lookup data in `compatibilityParams`, which means that we no longer need to export this Object. Based on these changes, it's now possible to simplify some existing code in `AppOptions` by taking full advantage of the nullish coalescing (`??`) operator.
Snuffleupagus
force-pushed
the
validate-defaultOptions
branch
from
3d38e09
to
38004b6
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/655caa29cb2c93b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/655caa29cb2c93b/output.txt Total script time: 1.23 mins Published |
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/40505e54592ed46/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/72f5b40c2de57d1/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/72f5b40c2de57d1/output.txt Total script time: 24.75 mins
Image differences available at: http://54.241.84.105:8877/72f5b40c2de57d1/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/40505e54592ed46/output.txt Total script time: 39.18 mins
Image differences available at: http://54.193.163.58:8877/40505e54592ed46/reftest-analyzer.html#web=eq.log |
Given that the "PREFERENCE" kind is used e.g. to generate the preference-list for the Firefox PDF Viewer, those options need to be carefully validated.
With this patch we'll now check this unconditionally in development mode, during testing, and when creating the preferences in the gulpfile.