Remove PDFViewerApplication.initPassiveLoading and directly invoke the open-method from the extension-specific code
#17813
Conversation
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5cb8d72276526b2/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/5cb8d72276526b2/output.txt Total script time: 1.22 mins Published |
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b46514e77a9bdf9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/b702efa2e5d3010/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b46514e77a9bdf9/output.txt Total script time: 6.95 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/b702efa2e5d3010/output.txt Total script time: 18.93 mins
|
…Error` When reporting errors in the viewer we currently localize the error messages "manually" at every call-site, which seems like unnecessary repetition.
…the `open`-method from the extension-specific code This old method is essentially just adding, a small amount of, unnecessary indirection and we can easily invoke `PDFViewerApplication.open` directly from the extension-specific code instead.
Snuffleupagus
force-pushed
the
initPassiveLoading-simplify
branch
from
243f02b
to
ea1c910
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4c4303e89f71809/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/4c4303e89f71809/output.txt Total script time: 1.21 mins Published |
|
Looks like a good simplification; thanks! |
Move the error message localization into
PDFViewerApplication._otherErrorWhen reporting errors in the viewer we currently localize the error messages "manually" at every call-site, which seems like unnecessary repetition.
Remove
PDFViewerApplication.initPassiveLoadingand directly invoke theopen-method from the extension-specific codeThis old method is essentially just adding, a small amount of, unnecessary indirection and we can easily invoke
PDFViewerApplication.opendirectly from the extension-specific code instead.