A couple of small tweaks of the BasePreferences class
#17842
Conversation
- Use slightly shorter variable names when initializing the preferences. - Correctly copy the "old" preference-values before writing to storage, since Objects are passed by reference in JavaScript. (Only applies to the GENERIC viewer.) - Use `await` fully when writing new preference-values to storage. (Only applies to the GENERIC viewer.) - Stub the `get`-method in the Firefox PDF Viewer, since it's unused there nowadays.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/65d5fdbb055dd9d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/65d5fdbb055dd9d/output.txt Total script time: 1.27 mins Published |
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/f488ac6607488fc/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/2269e3ad72444e5/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/2269e3ad72444e5/output.txt Total script time: 7.48 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/f488ac6607488fc/output.txt Total script time: 19.56 mins
|
|
Looks good! |
awaitfully when writing new preference-values to storage. (Only applies to the GENERIC viewer.)get-method in the Firefox PDF Viewer, since it's unused there nowadays.