Limit all compatibilityParams handling to the GENERIC viewer
#17861
Conversation
With recent improvements to the `AppOptions`, e.g. with better validation and testing, one remaining "annoyance" is the `compatibilityParams` handling. Especially since there's only *a single* parameter left, limited to GENERIC builds. To further reduce the amount of unnecessary code in e.g. the Firefox PDF Viewer, we can move the `compatibilityParams` handling into the user-options instead since that keeps the previous precedence order between default/user-options.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/40a0c8dbaff6032/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/40a0c8dbaff6032/output.txt Total script time: 1.23 mins Published |
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/db4d2dbe6c794e4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/f4759dd64b53c8f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/db4d2dbe6c794e4/output.txt Total script time: 7.44 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/f4759dd64b53c8f/output.txt Total script time: 21.27 mins
|
|
Looks great; thanks for simplifying this! |
With recent improvements to the
AppOptions, e.g. with better validation and testing, one remaining "annoyance" is thecompatibilityParamshandling. Especially since there's only a single parameter left, limited to GENERIC builds.To further reduce the amount of unnecessary code in e.g. the Firefox PDF Viewer, we can move the
compatibilityParamshandling into the user-options instead since that keeps the previous precedence order between default/user-options.