Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the addWindowResolutionChange listener unconditionally (PR 17767 follow-up) #17865

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

Given that PDFViewerApplication.unbindWindowEvents can be invoked in mozilla-central tests, we should ensure that the listener is always removed.

…7767 follow-up)

Given that `PDFViewerApplication.unbindWindowEvents` can be invoked in mozilla-central tests, we should ensure that the listener is always removed.
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0fbfaf5a108f558/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/0fbfaf5a108f558/output.txt

Total script time: 1.23 mins

Published

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit 3b87c31 into mozilla:master Apr 1, 2024
7 checks passed
@Snuffleupagus Snuffleupagus deleted the pr-17767-followup branch April 1, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants