Modernize the TTX driver code #17890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original `test.py` code, see https://github.com/mozilla/pdf.js/blob/c2376e5cea1b3cee89d77e6a4e8b0d9b5b8591be/test/test.py, did not have any timeout logic for TTX, but it got introduced when `test.py` was ported from Python to JavaScript as `test.js` in mozilla@c2376e5#diff-a561630bb56b82342bc66697aee2ad96efddcbc9d150665abd6fb7ecb7c0ab2f. However, I don't think we've ever actually seen TTX timing out. Moreover, back then we used a very old version of TTX and ran the font tests on the bots (where a hanging process would block other jobs and would require a manual action to fix), so this code was most likely only included defensively. Fortunately, nowadays it should not be necessary anymore because we use the most recent version of TTX (which either returns the result or errors out, but isn't known to hang on inputs) and we run the font tests on GitHub Actions which doesn't block other jobs anymore and also automatically times the job out for us in the unlikely event that a hang would ever occur. In short, we can safely remove this logic to simplify the code and to get rid of a callback.
This commit removes the final callbacks in this code by switching to a promises-based interface, overall simplifying the code. Moreover, we document why we write to files on disk and modernize the code using e.g. template strings.
timvandermeij
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit messages contain more details about the individual changes.