Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect maxCanvasPixels when computing canvas dimensions #18218

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Respect maxCanvasPixels when computing canvas dimensions #18218

merged 2 commits into from
Jun 19, 2024

Commits on Jun 19, 2024

  1. Add test for CSS-only zoom above maxCanvasPixels 

    This commit introduces a test to ensure that:
- When zooming below the maxCanvasPixels limit, the canvas is rendered
  with the correct size (the two sides are multiplied by the zoom factor).
- When zooming above the maxCanvasPixels limit, the canvas size is capped.
    @nicolo-ribaudo
    nicolo-ribaudo committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    12692d2 View commit details
    Browse the repository at this point in the history

  2. Respect maxCanvasPixels when computing canvas dimensions 

    Ensure that we never round the canvas dimensions above `maxCanvasPixels`
by rounding them to the preceeding multiple of the display ratio rather
than the succeeding one.
    @nicolo-ribaudo
    nicolo-ribaudo committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    de23bb9 View commit details
    Browse the repository at this point in the history