Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new formatted issue templates #18308

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

nicolo-ribaudo
Copy link
Contributor

You can test this at https://github.com/nicolo-ribaudo/pdf.js/issues, and nicolo-ribaudo#1 is an example of the generated issue. It's unfortunate that all the small questions (such as "Operating system and its version") get their own header, but hopefully it will help with getting all the necessary info filled in properly.

.github/ISSUE_TEMPLATE/bug.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature.yml Show resolved Hide resolved
@nicolo-ribaudo
Copy link
Contributor Author

It seems like there is no way to have a yes/no required option whose default value is "unselected". I made the questions about "does this happen in the latest version" and "is this relevant to Firefox" default to no.

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, thank you for doing this!

(Not landing this right away, simply to give other core contributors a chance to comment.)

@timvandermeij
Copy link
Contributor

I have requested a review from myself and @calixteman as additional sign-off on this. I'll try to have this reviewed tomorrow.

@calixteman calixteman requested a review from marco-c June 20, 2024 18:37
@marco-c
Copy link
Contributor

marco-c commented Jun 21, 2024

LGTM!
Question: should we have "Is the bug present in the latest PDF.js version?" be "Yes" by default since that should be the most common answer?

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too, and I think I agree with the comment from @marco-c that that's probably a better default value for most issues.

@nicolo-ribaudo
Copy link
Contributor Author

Default updated 👍

@timvandermeij timvandermeij merged commit ba0e732 into mozilla:master Jun 21, 2024
7 checks passed
@timvandermeij
Copy link
Contributor

Now that all four approvals are in and the discussed feedback is addressed, let's do this. This should increase the quality of the bug reports, and if need be we can always tweak it further. Thank you for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants