Fix the repository URL in the package.json file for pdfjs-dist
#18358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For provenance, enabled in PR mozilla#18352, to work the repository URL in `package.json` is required to match the repository URL of the GitHub Actions invocation. This should fix the following error we encountered publishing a new release today: ``` npm error 422 Unprocessable Entity - PUT https://registry.npmjs.org/pdfjs-dist - Error verifying sigstore provenance bundle: Failed to validate repository information: package.json: "repository.url" is "git+https://github.com/mozilla/pdfjs-dist.git", expected to match "https://github.com/mozilla/pdf.js" from provenance ```
|
I have unpublished the release/tag of the failed release and will retry once this lands. Note that nothing had been pushed to NPM yet. |
Snuffleupagus
approved these changes
Jul 1, 2024
timvandermeij
added a commit
to timvandermeij/pdf.js
that referenced
this pull request
Jul 13, 2024
The Git logic for pushing to the `pdfjs-dist` repository was already removed in PR mozilla#18350, but it was forgotten to also remove the logic to create a Git repository in the first place. This commit fixes the open action for that from mozilla#18358 (comment). Moreover, we implement the suggestion from mozilla#18358 (comment) about moving the Git URL to a separate variable for consistency and we update the homepage URL to the HTTPS scheme to avoid an HTTP -> HTTPS redirect and enforce TLS-encrypted connections.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For provenance, enabled in PR #18352, to work the repository URL in
package.jsonis required to match the repository URL of the GitHub Actions invocation. This should fix the following error we encountered publishing a new release today:Notes:
git+format URL as we do, and thereact-pdfproject also uses it with provenance enabled successfully, so the format itself should not be the issue and only the repository name itself is.