[Editor] Make stamp annotations editable (bug 1921291)

[calixteman]

No description provided.

[calixteman]

/botio integrationtest

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e7f10fe2e8e301a/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d767c20151edf8c/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/d767c20151edf8c/output.txt

Total script time: 9.69 mins

• Integration Tests: Passed

[calixteman]

/botio-linux preview

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/bf341dd919fff72/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/bf341dd919fff72/output.txt

Total script time: 1.02 mins

Published

• Viewer: http://54.241.84.105:8877/bf341dd919fff72/web/viewer.html
• Viewer (legacy): http://54.241.84.105:8877/bf341dd919fff72/legacy/web/viewer.html

[moz-tools-bot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/e7f10fe2e8e301a/output.txt

Total script time: 22.13 mins

• Integration Tests: FAILED

[Snuffleupagus]

Given the changes here, please also run the full test-suite when the comments have been addressed.

[Snuffleupagus]

r=me, with the comments addressed and the full test-suite passing; thank you.

Given that the structTree is now being used in the editor-layer as well, we need to change this code

pdf.js/web/pdf_page_view.js

Lines 1101 to 1106 in ebbd019

	if (this.textLayer || this.annotationLayer) {
	this.structTreeLayer ||= new StructTreeLayerBuilder(
	pdfPage,
	viewport.rawDims
	);
	}

into just (i.e. initialize it unconditionally)

        this.structTreeLayer ||= new StructTreeLayerBuilder(
          pdfPage,
          viewport.rawDims
        );

[calixteman]

/botio test

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/967df609ff6631f/output.txt

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/b5709aa053e413b/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/967df609ff6631f/output.txt

Total script time: 31.58 mins

• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

  different ref/snapshot: 15
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/967df609ff6631f/reftest-analyzer.html#web=eq.log

[moz-tools-bot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/b5709aa053e413b/output.txt

Total script time: 47.14 mins

• Unit tests: Passed
• Integration Tests: FAILED
• Regression tests: FAILED

  different ref/snapshot: 3

Image differences available at: http://54.193.163.58:8877/b5709aa053e413b/reftest-analyzer.html#web=eq.log