Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawing without fillText; refactoring ADD_TO_PATH #3195

Merged
merged 1 commit into from
May 21, 2013

Conversation

yurydelendik
Copy link
Contributor

WIP for custom font renderer

The patch removes usage of the getImageData/putImageData in the cavnas.js for ADD_TO_PATH operations (see #1687).

Also somewhat addresses #2414

@yurydelendik
Copy link
Contributor Author

/botio-windows preview

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2013

From: Bot.io (Windows)


Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/6307be9cb728403/output.txt

@yurydelendik
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2013

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 1

Live output at: http://107.22.172.223:8877/b18498b90683a4a/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2013

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/8d652e8910e1d3e/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2013

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2013

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/8d652e8910e1d3e/output.txt

Total script time: 22.01 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/8d652e8910e1d3e/reftest-analyzer.xhtml#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2013

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/b18498b90683a4a/output.txt

Total script time: 26.02 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/b18498b90683a4a/reftest-analyzer.xhtml#web=eq.log

@yurydelendik
Copy link
Contributor Author

/botio-windows preview

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2013

From: Bot.io (Windows)


Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/b46a6ad007ac4a9/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2013

@yurydelendik
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/8eba57168633682/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/c5f72ac31c1e3a1/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/8eba57168633682/output.txt

Total script time: 23.13 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/8eba57168633682/reftest-analyzer.xhtml#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/c5f72ac31c1e3a1/output.txt

Total script time: 27.20 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/c5f72ac31c1e3a1/reftest-analyzer.xhtml#web=eq.log

@@ -0,0 +1,712 @@
/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is for fonts only, how about font_renderer.js?

@yurydelendik
Copy link
Contributor Author

Comments above are addressed.

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/583151fcca6871f/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/1927e2608398b75/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/583151fcca6871f/output.txt

Total script time: 23.00 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/583151fcca6871f/reftest-analyzer.xhtml#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/1927e2608398b75/output.txt

Total script time: 26.93 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/1927e2608398b75/reftest-analyzer.xhtml#web=eq.log

@brendandahl
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/9845d27c4b54787/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://107.21.233.14:8877/78b9ad842328f7d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/78b9ad842328f7d/output.txt

Total script time: 22.09 mins

  • Lint: FAILED
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/9845d27c4b54787/output.txt

Total script time: 25.54 mins

  • Lint: Ignored
  • Make references: Passed
  • Check references: Passed

brendandahl added a commit that referenced this pull request May 21, 2013
Drawing without fillText; refactoring ADD_TO_PATH
@brendandahl brendandahl merged commit efde079 into mozilla:master May 21, 2013
@timvandermeij
Copy link
Contributor

@brendandahl: just curious, but why does bot.io say 'Failed' on Linux when the log says that everything went OK?

EDIT: I didn't see the linting fail. However, is that not a problem?

@brendandahl
Copy link
Contributor

Something is wrong with the jshint install. I'm going to check it out later, not really a problem though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants