Disallow anonymous function declarations #1418
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-bakker
added
the
Ecma Incompatibility
But i think we need at least some test in our test suite for this |
|
This seems OK to me but it should definitely be gated by a language version (ES6 works for me). I suspect that there are no tests because this is basically invalid syntax that I suspect the test authors didn't expect. We should write a few of our own tests for this just to exercise the code path. |
|
K, will add the language flag and tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EcmaScript doesn't allow anonymous function declarations, only function expressions can be anonymous.
Rhino does allow anonymous function declarations, but this PR fixes it.
Test262 doesn't have any test for this (or at least not the test262 version we're currently on), so tests are missing
More importantly though, should this fix be tied to a specific language version? If so, everyone OK with >= ES6?
Fixes #577