-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy and Reflect implementation #1637
base: master
Are you sure you want to change the base?
Conversation
e195119
to
ec6f9dd
Compare
Not possible to continue with the previous PR? This way we may lose the (unresolved) comments |
1e1aa7b
to
b5cf850
Compare
As promised i have recreated the Proxy/Reflect stuff based on the current status of the impl. From my point of view this is already in a state that can be merged - i will not really work on this because i have some other priorities. Will try to rebase from time to time.... Status
|
Could you elaborate on which breaking changes are needed to make Proxy more spec-compliant? From looking at all comment on this and the two preceding PRs, I gathered the following: Included breaking change: defineProperty now returns boolean instead of void Are there more changes that ought to be made, but that you held off on as they would constitute a breaking change? Also, some of my previous comments remain unanswered. Any chance you can have a look at them?
And wrt to whether this is mergeable in its current state or not: I worry that there are details of the spec that haven't been implemented yet and that do not relate to requiring breaking changes, for example (some completely random checks on currently failing tests):
Not trying to be pedantic about this, I really wanna see Proxy support merged (heck, I opened the issue about it 8 and a half years ago :-) ), am just worried about A: merging something that isn't as spec compliant as it can be, meaning we'll have to make (potentially) breaking changes later and B: that if we don't take care of the details now, we'll never get to tme |
…62.properties with jdk 11 and some minor fixes
ffd9a0f
to
cfa7913
Compare
cfa7913
to
874a94f
Compare
Next try on the long story.... see #268
This is the follow up of #1431.