Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Version bump opendal 0.41.0 -> 0.43.0 #1992

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

vincentdephily
Copy link
Contributor

Remove the opendal/services-redis-rustls feature as it's no longer available/needed.

Obsoletes #1957

@sylvestre
Copy link
Collaborator

A bunch of tasks are failing here

@vincentdephily
Copy link
Contributor Author

vincentdephily commented Nov 29, 2023

I managed to reproduce the errors by building with rust 1.71, and they go away with 1.72 and higher.

What puzzles me is that the CI seems to be using 1.67.1, but I get a bunch of different errors with 1.67-1.71, including fairly basic things like the clap crates crates in our Cargo.lock having an MSRV of 1.70. Does the CI really manages to do some builds with 1.67 ? Is it resolving minimal dependencies maybe ?

What's sccache's MSRV update policy ? Note that working with anything older than 1.70 has become a pain, due to fetching crate metadata using git instead of sparse registry.

@vincentdephily
Copy link
Contributor Author

Sorry, ignore my previous observation about failures with 1.67-1.70, I had locally updated all deps by mistake.

The build failure with my branch does get resolved with 1.72, but that's a more isolated problem.

@vincentdephily
Copy link
Contributor Author

Fix proposed upstream in Opendal. For this MR we'll probably want to wait for the next Opendal release.

@sylvestre
Copy link
Collaborator

the maintainer of opendal is also a maintainer here :)
So, should not be hard ;)
cc @Xuanwo ;)

@Xuanwo
Copy link
Collaborator

Xuanwo commented Nov 30, 2023

Fix proposed upstream in Opendal. For this MR we'll probably want to wait for the next Opendal release.

Let's coordinate this. I have ping the release manager to see if we can include this fix in the coming release.

@Xuanwo Xuanwo changed the title Versionbump opendal 0.40.0 -> 0.42.0 chore: Version bump opendal 0.40.0 -> 0.42.0 Dec 1, 2023
@Xuanwo
Copy link
Collaborator

Xuanwo commented Dec 1, 2023

OpenDAL v0.43.0 is currently up for voting and we anticipate its availability by next week.

@vincentdephily vincentdephily changed the title chore: Version bump opendal 0.40.0 -> 0.42.0 chore: Version bump opendal 0.41.0 -> 0.43.0 Dec 8, 2023
@vincentdephily
Copy link
Contributor Author

Rebased on main, and now upgrading to 0.43.0 instead, along with a few dependencies.

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (286554c) 30.80% compared to head (07aefc0) 30.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1992      +/-   ##
==========================================
- Coverage   30.80%   30.64%   -0.16%     
==========================================
  Files          51       51              
  Lines       19419    19539     +120     
  Branches     9349     9430      +81     
==========================================
+ Hits         5982     5988       +6     
- Misses       7790     7905     +115     
+ Partials     5647     5646       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Remove the `opendal/services-redis-rustls` feature as it's no longer available/needed.
@vincentdephily
Copy link
Contributor Author

Gah, I had done the necessary ordered-multimap downgrade locally but forgot to amend my commit, sorry. Should be fixed.

Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Xuanwo Xuanwo merged commit 855ec0f into mozilla:main Dec 14, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants