-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Version bump opendal 0.41.0 -> 0.43.0 #1992
Conversation
A bunch of tasks are failing here |
I managed to reproduce the errors by building with rust 1.71, and they go away with 1.72 and higher. What puzzles me is that the CI seems to be using 1.67.1, but I get a bunch of different errors with 1.67-1.71, including fairly basic things like the clap crates crates in our Cargo.lock having an MSRV of 1.70. Does the CI really manages to do some builds with 1.67 ? Is it resolving minimal dependencies maybe ? What's sccache's MSRV update policy ? Note that working with anything older than 1.70 has become a pain, due to fetching crate metadata using git instead of sparse registry. |
Sorry, ignore my previous observation about failures with 1.67-1.70, I had locally updated all deps by mistake. The build failure with my branch does get resolved with 1.72, but that's a more isolated problem. |
Fix proposed upstream in Opendal. For this MR we'll probably want to wait for the next Opendal release. |
the maintainer of opendal is also a maintainer here :) |
Let's coordinate this. I have ping the release manager to see if we can include this fix in the coming release. |
OpenDAL v0.43.0 is currently up for voting and we anticipate its availability by next week. |
d09b9e1
to
b41f572
Compare
Rebased on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1992 +/- ##
==========================================
- Coverage 30.80% 30.64% -0.16%
==========================================
Files 51 51
Lines 19419 19539 +120
Branches 9349 9430 +81
==========================================
+ Hits 5982 5988 +6
- Misses 7790 7905 +115
+ Partials 5647 5646 -1 ☔ View full report in Codecov by Sentry. |
Remove the `opendal/services-redis-rustls` feature as it's no longer available/needed.
b41f572
to
07aefc0
Compare
Gah, I had done the necessary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Remove the
opendal/services-redis-rustls
feature as it's no longer available/needed.Obsoletes #1957