Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove openssl dependency for GCS #367

Merged
merged 3 commits into from
Feb 8, 2019
Merged

Remove openssl dependency for GCS #367

merged 3 commits into from
Feb 8, 2019

Conversation

Jake-Shadle
Copy link
Contributor

This is a slight reimplementation of #272 that I think works slightly better.

  • It doesn't add a dependency on pem which seems like overkill for just parsing a key out, at least if it's only going to be used for GCS specifically. This just uses a simple string split since the key format is not complicated.
  • I opened a PR here Attempt to fallback to pkcs8 if der fails Keats/jsonwebtoken#74 to enable the key to be passed "as-is" rather than converting it to DER. It looks like a v7 discussion Keats/jsonwebtoken#76 of jsonwebtoken coming, which might remove this API ambiguity, but for now pointing at the fork allows GCS to function properly, without OpenSSL.

@Jake-Shadle
Copy link
Contributor Author

Went ahead and removed the now superfluous all-windows feature flag.

@luser
Copy link
Contributor

luser commented Feb 5, 2019

Thanks for the patch! I'll try to take a look at this today.

@luser
Copy link
Contributor

luser commented Feb 8, 2019

OK, I'm going to land this as-is. I don't love having crates.io patches because they complicate pushing new releases, but hopefully the jsonwebtoken API situation will get sorted out and we can switch back to an upstream release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants